-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test setup using react-hooks-testing-library #11
Comments
I have been thinking about it, but haven't had the time. PR welcome! |
Great. I'll give it a try.
…On Tue, 31 Dec, 2019, 7:48 pm Herman Starikov, ***@***.***> wrote:
I have been thinking about it, but haven't had the time. PR welcome!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11?email_source=notifications&email_token=AAXVDXWH46CFKLGG77DCDK3Q3NIBTA5CNFSM4KBU2IP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH4IOKQ#issuecomment-569935658>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXVDXWYDGBUKQYSZWYLFALQ3NIBTANCNFSM4KBU2IPQ>
.
|
So, just to clarify - are you currently running travis ci on the hooks that you made with this lib? In my repo, travis tests are failing on node 9 - because typescript-eslint doesn't seem to support that specific version. With node 8, 10, 11 - everything is fine. |
create-react-hook is based on create-react-library, and I'm guessing since the fork travis has removed support for that node version. |
No, its not because of travis itself. Ex: https://travis-ci.org/bendtherules/some-hooks/jobs/631280716 . |
Added a PR for this. #12 |
Consider adding react-hooks-testing-library for testing custom hooks separately - sort of like unit tests. This should be part of src/tests.
Examples folder can be kept for demo purpose and integration testing
The text was updated successfully, but these errors were encountered: