Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test setup using react-hooks-testing-library #11

Closed
bendtherules opened this issue Dec 31, 2019 · 6 comments · Fixed by #12
Closed

Add test setup using react-hooks-testing-library #11

bendtherules opened this issue Dec 31, 2019 · 6 comments · Fixed by #12

Comments

@bendtherules
Copy link
Contributor

Consider adding react-hooks-testing-library for testing custom hooks separately - sort of like unit tests. This should be part of src/tests.
Examples folder can be kept for demo purpose and integration testing

@Hermanya
Copy link
Owner

I have been thinking about it, but haven't had the time. PR welcome!

@bendtherules
Copy link
Contributor Author

bendtherules commented Dec 31, 2019 via email

@bendtherules
Copy link
Contributor Author

So, just to clarify - are you currently running travis ci on the hooks that you made with this lib?
Couldn't find public builds with your username there.

In my repo, travis tests are failing on node 9 - because typescript-eslint doesn't seem to support that specific version. With node 8, 10, 11 - everything is fine.
Do you know a workaround for this? I just removed 9 from travis node versions for now.

@Hermanya
Copy link
Owner

create-react-hook is based on create-react-library, and I'm guessing since the fork travis has removed support for that node version.
I don't even have travis ci set up in this repo :D

@bendtherules
Copy link
Contributor Author

create-react-hook is based on create-react-library, and I'm guessing since the fork travis has removed support for that node version.

No, its not because of travis itself. Ex: https://travis-ci.org/bendtherules/some-hooks/jobs/631280716 .
@typescript-eslint/eslint-plugin doesn't seem to support node 9 specifically.

@bendtherules
Copy link
Contributor Author

Added a PR for this. #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants