Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove exit-tree, add exitBalance and accHash in state #45

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

krlosMata
Copy link
Contributor

@krlosMata krlosMata commented Jul 9, 2021

This PR does the following:

  • updates circuits to remove the exit-tree
  • add accumulatedHash and exitBalance
  • add option to extend circom to debug properly and reuse compiled circuits

Update circuits summary

balance-updater

  • add computing exitBalance for receiver leaf if transaction is an exit
  • remove unnecessary signal isP2Nop

decode-tx

  • add computation of L1L2TxsData in integer

fee-tx

  • update leaf with exitBlance and accumulatedHash

hash-inputs

  • remove exitRoot

rollup-main

  • remove intermnediary signal imExitRoot
  • remove newExit flag
  • remove signals for inserts on Processor2: isOld0_2, oldKey2 & oldValue2
  • add new state fields: exitBalance & accumulatedHash
  • L1L2TxsData is 0 if transaction is onChain

rollup-tx-states

  • remove insertions on processor2
  • update processor2 functions

rollup-tx

  • compute accumulated hash
  • remove selectors when processor2 was performing an insert
  • remove exit root computation

Extend circom

  • npm run extend-circom will add extra functionality to circom in order to debug circuits
  • reuse and pathTmp should be set correctly if a circuit wants to be reused

close #38

Copy link
Contributor

@laisolizq laisolizq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸


// E - signal processor selectors
////////
// decode BjjCompressed
// decode BjjCompumulatedressed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor

@invocamanman invocamanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! ^^

@invocamanman invocamanman merged commit eeeac96 into feature/upgrade-v1 Jul 14, 2021
This was referenced Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants