-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove exit-tree, add exitBalance and accHash in state #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4708362
to
a411fb3
Compare
laisolizq
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
src/rollup-tx.circom
Outdated
|
||
// E - signal processor selectors | ||
//////// | ||
// decode BjjCompressed | ||
// decode BjjCompumulatedressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
b74d8ee
to
499171d
Compare
499171d
to
4ec567a
Compare
invocamanman
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! ^^
This was referenced Jul 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
accumulatedHash
andexitBalance
Update circuits summary
balance-updater
isP2Nop
decode-tx
fee-tx
exitBlance
andaccumulatedHash
hash-inputs
exitRoot
rollup-main
imExitRoot
newExit
flagisOld0_2
,oldKey2
&oldValue2
exitBalance
&accumulatedHash
onChain
rollup-tx-states
rollup-tx
Extend circom
npm run extend-circom
will add extra functionality to circom in order to debug circuitsreuse
andpathTmp
should be set correctly if a circuit wants to be reusedclose #38