Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File mode passed to uhyve is given in hex instead of octal. #191

Closed
jounathaen opened this issue May 17, 2021 · 1 comment
Closed

File mode passed to uhyve is given in hex instead of octal. #191

jounathaen opened this issue May 17, 2021 · 1 comment
Assignees
@stlankes

Comments

@jounathaen
Copy link
Member

The mode in the open hypercall is passed in hex, but it should be passed as octal. This results in strange permissions of files which are created by uhyve.

https://github.com/hermitcore/libhermit-rs/blob/44eaa9f693566413884f505552f74f2e25863e78/src/syscalls/interfaces/mod.rs#L58-L69

Example: 1991 = 0x777 is passed but it should be 511 = 0o777 instead. The flags field is passed correctly.

@tlambertz pointed out that this has to be fixed in the stdlib
@stlankes stlankes mentioned this issue Mar 19, 2023
Merged
stlankes added a commit to hermit-os/rust that referenced this issue Mar 19, 2023
@stlankes
fix typo in the creation of OpenOption
05542d9 
Due to this typo we have to build a workaround for issue
hermit-os/kernel#191.

RustyHermit is a tier 3 platform and backward compatibility does
not have to be guaranteed.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#109368 - hermitcore:typo, r=cuviper
cca2630 
fix typo in the creation of OpenOption for RustyHermit

Due to this typo we have to build a workaround for issue hermit-os/kernel#191.

RustyHermit is a tier 3 platform and backward compatibility does not have to be guaranteed.
@mkroening
Copy link
Member

Fixed by rust-lang/rust#109368.

thomcc pushed a commit to tcdi/postgrestd that referenced this issue Jun 1, 2023
@stlankes
fix typo in the creation of OpenOption
5a3494b 
Due to this typo we have to build a workaround for issue
hermit-os/kernel#191.

RustyHermit is a tier 3 platform and backward compatibility does
not have to be guaranteed.
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Jun 1, 2023
@matthiaskrgr
Rollup merge of #109368 - hermitcore:typo, r=cuviper
9a5d53c 
fix typo in the creation of OpenOption for RustyHermit

Due to this typo we have to build a workaround for issue hermit-os/kernel#191.

RustyHermit is a tier 3 platform and backward compatibility does not have to be guaranteed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stlankes stlankes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stlankes @jounathaen @mkroening