Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtq refactor #1174

Merged
merged 3 commits into from
May 15, 2024
Merged

Virtq refactor #1174

merged 3 commits into from
May 15, 2024

Commits on May 15, 2024

  1. virtq: remove Transfer 

    Transfer was a wrapper around TransferToken, which in turn is a wrapper around BufferToken with the state of the transfer and the queue which the transfer is to be returned. The receiving queues do not need a reference to themselves and the transfer state is no longer needed as a variable since we do not share the transfer with the caller while the transfer in process. As a result, we are able to replace the uses of Transfer with BufferToken. Most methods on Transfer are also wrappers around the underlying BufferToken and could be removed in entirely. Those that didn't have an exact analogue in the implementation of BufferToken were moved there.
    @cagatay-y @mkroening
    cagatay-y authored and mkroening committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f185bb0 View commit details
    Browse the repository at this point in the history

  2. virtq: remove TransferState 

    The TransferState was needed to check the status of the Transfer when it was shared between the caller and the callee. However, this is no longer the case and the caller cannot access a in-progress transfer anymore. Thus, the related checks are no longer needed and the field is no longer necessary.
    @cagatay-y @mkroening
    cagatay-y authored and mkroening committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6ada7a6 View commit details
    Browse the repository at this point in the history

  3. virtq: use async_channel for moving buffers to the callers

    @cagatay-y @mkroening
    cagatay-y authored and mkroening committed May 15, 2024
    Configuration menu
    Copy the full SHA
    94bc283 View commit details
    Browse the repository at this point in the history