fix bug by building the minimal version of libhermit #160

stlankes · 2021-01-20T09:26:25Z

This PR should solve issue #157 In addition, I add a small test to build the minimal configuration.

This reverts commit 339abc2.

stlankes · 2021-01-21T07:02:32Z

@jschwe It seems to work...

jschwe · 2021-01-21T08:33:59Z

@stlankes Have you tried building and running an application?
I get a lot of GP Exceptions when trying to run hello-world with no-default-features and this PR, but maybe I'm doing something wrong.
Steps:

Checkout master of rusty-hermit
Checkout this PR into libhermit-rs
go back to rusty-hermit directory
cargo build --manifest-path examples/hello_world/Cargo.toml --target x86_64-unknown-hermit --no-default-features
cd loader && make && cd ..
qemu-system-x86_64 -display none -smp 1 -m 64M -serial stdio -kernel loader/target/x86_64-unknown-hermit-loader/debug/rusty-loader -initrd target/x86_64-unknown-hermit/debug/pi_sequential -cpu qemu64,apic,fsgsbase,rdtscp,xsave,fxsr

stlankes · 2021-01-21T08:57:16Z

It works only on uhyve, QEMU depends on PCI.... That is the reason, why I don't test it within GitHub Actions. In the future, I want to support of Qemu's Micro VM (https://github.com/bonzini/qemu/blob/master/docs/microvm.rst). Currently, it doesn't run on it. I have to check, why it isn't working on this setup.

jschwe · 2021-01-21T09:14:04Z

Ah okay, that explains it.
I suggest to build the minimal kernel with --target x86_64-unknown-hermit-kernel and remove the std from -Z build-std=<>.
In practice, it's not really relevant of course, since we aren't using the binary, but I think it's better to stay consistent regarding the different parameters when building the kernel vs an application.
Other than that the PR looks good.

stlankes · 2021-01-21T09:17:54Z

You are right, I fixed it

jschwe · 2021-01-20T15:07:01Z

.github/workflows/nightly.yml

@@ -88,6 +88,9 @@ jobs:
          echo "C:\Program Files\qemu" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
          echo "C:\Program Files\nasm" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
        if: ${{ matrix.os == 'windows-latest' }}
+      - name: Building minimal kernel
+        run:
+          cargo build -Z build-std=std,core,alloc,panic_abort --target x86_64-unknown-hermit --manifest-path=Cargo.toml --no-default-features


I think you need to specify the crate you want to build with --no-default-features, e.g. by adding -p rusty_demo.

stlankes · 2021-01-21T09:52:05Z

bors r+

160: fix bug by building the minimal version of libhermit r=stlankes a=stlankes This PR should solve issue #157 In addition, I add a small test to build the minimal configuration. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: Stefan Lankes <stlankes@users.noreply.github.com>

bors · 2021-01-21T10:34:31Z

Build failed:

ci/gitlab/git.rwth-aachen.de

stlankes · 2021-01-21T15:41:10Z

bors retry

160: fix bug by building the minimal version of libhermit r=stlankes a=stlankes This PR should solve issue #157 In addition, I add a small test to build the minimal configuration. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: Stefan Lankes <stlankes@users.noreply.github.com>

bors · 2021-01-21T16:27:48Z

Build failed:

ci/gitlab/git.rwth-aachen.de

jschwe · 2021-01-21T19:57:31Z

It appears that both the integration tests and the multithreaded uhyve test is failing. The multithreaded uhyve tests crashes, but still seems to exit with 0, which causes the test to appear as passed, even though it should have failed. I'll open an issue over at uhyve to track this (Edit: We already have issue 7 tracking this)
The integration tests seem to be running fine, but uhyve (or possibly also libhermit) doesn't exit after they are finished.

I also noticed, that the way I'm dumping the stdout in the integration tests does not really result in very readable output, so I'll open a PR to improve that in the next days.

The current version of integration tests crahs sometime. This is failure in uhyve and temporary disable these tests.

stlankes · 2021-01-22T19:37:05Z

bors r+

160: fix bug by building the minimal version of libhermit r=stlankes a=stlankes This PR should solve issue #157 In addition, I add a small test to build the minimal configuration. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: Stefan Lankes <stlankes@users.noreply.github.com>

A valid exit code means that a thread calls the system call `exit`. In this case, we have to terminate all threads like the behaviour of `exit`. This current version is the reason that PR `hermit-os/kernel#160` doesn't pass all tests.

bors · 2021-01-22T20:57:42Z

Build failed:

ci/gitlab/git.rwth-aachen.de

68: revise exit handling r=stlankes a=stlankes A valid exit code means that a thread calls the system call `exit`. In this case, we have to terminate all threads like the behaviour of `exit`. This current version is the reason that PR `hermit-os/kernel#160` doesn't pass all tests. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>

A valid exit code means that a thread calls the system call `exit`. In this case, we have to terminate all threads like the behaviour of `exit`. This current version is the reason that PR `hermit-os/kernel#160` doesn't pass all tests.

68: revise exit handling r=stlankes a=stlankes A valid exit code means that a thread calls the system call `exit`. In this case, we have to terminate all threads like the behaviour of `exit`. This current version is the reason that PR `hermit-os/kernel#160` doesn't pass all tests. Co-authored-by: Jens Breitbart <jbreitbart@gmail.com> Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>

stlankes · 2021-01-24T00:10:20Z

bors r+

160: fix bug by building the minimal version of libhermit r=stlankes a=stlankes This PR should solve issue #157 In addition, I add a small test to build the minimal configuration. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: Stefan Lankes <stlankes@users.noreply.github.com>

bors · 2021-01-24T00:26:17Z

Build failed:

ci/gitlab/git.rwth-aachen.de

stlankes · 2021-01-24T00:27:17Z

bors r+

bors · 2021-01-24T00:51:12Z

Build succeeded:

160: fix bug by building the minimal version of libhermit r=stlankes a=stlankes This PR should solve issue hermit-os#157 In addition, I add a small test to build the minimal configuration. Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de> Co-authored-by: Stefan Lankes <stlankes@users.noreply.github.com>

stlankes added 4 commits January 19, 2021 20:46

add option to create a virtio device without pci support

339abc2

minor changes to build the kernel without PCI support

743e46a

add test to build the minimal configuration of the kernel

a687775

Revert "add option to create a virtio device without pci support"

198bf77

This reverts commit 339abc2.

stlankes requested a review from jschwe January 20, 2021 09:27

stlankes and others added 2 commits January 20, 2021 10:38

add path to the manifest

ab35a61

define libhermit-rs as working directory

d5d7c80

Build with the valid target

55b55aa

jschwe approved these changes Jan 21, 2021

View reviewed changes

stlankes mentioned this pull request Jan 21, 2021

libhermit-rs fails to compile without feature "pci" #157

Closed

stlankes added 2 commits January 22, 2021 20:30

allow failures during integration tests

1dfc54d

The current version of integration tests crahs sometime. This is failure in uhyve and temporary disable these tests.

Merge branch 'uhyve' of github.com:stlankes/libhermit-rs into uhyve

ae96b03

install always the latest version of uhyve

12c85cb

bors bot merged commit 0c2e966 into hermit-os:master Jan 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix bug by building the minimal version of libhermit #160

fix bug by building the minimal version of libhermit #160

stlankes commented Jan 20, 2021

stlankes commented Jan 21, 2021

jschwe commented Jan 21, 2021

stlankes commented Jan 21, 2021

jschwe commented Jan 21, 2021

stlankes commented Jan 21, 2021

jschwe Jan 20, 2021

stlankes commented Jan 21, 2021

bors bot commented Jan 21, 2021

stlankes commented Jan 21, 2021

bors bot commented Jan 21, 2021

jschwe commented Jan 21, 2021 •

edited

stlankes commented Jan 22, 2021

bors bot commented Jan 22, 2021

stlankes commented Jan 24, 2021

bors bot commented Jan 24, 2021

stlankes commented Jan 24, 2021

bors bot commented Jan 24, 2021

fix bug by building the minimal version of libhermit #160

fix bug by building the minimal version of libhermit #160

Conversation

stlankes commented Jan 20, 2021

stlankes commented Jan 21, 2021

jschwe commented Jan 21, 2021

stlankes commented Jan 21, 2021

jschwe commented Jan 21, 2021

stlankes commented Jan 21, 2021

jschwe Jan 20, 2021

Choose a reason for hiding this comment

stlankes commented Jan 21, 2021

bors bot commented Jan 21, 2021

stlankes commented Jan 21, 2021

bors bot commented Jan 21, 2021

jschwe commented Jan 21, 2021 • edited

stlankes commented Jan 22, 2021

bors bot commented Jan 22, 2021

stlankes commented Jan 24, 2021

bors bot commented Jan 24, 2021

stlankes commented Jan 24, 2021

bors bot commented Jan 24, 2021

jschwe commented Jan 21, 2021 •

edited