CI: Run rusty-hermit demo tests on PRs to libhermit-rs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
22 times, most recently
from
adde8df
to
e4a61eb
Compare
jschwe
changed the title
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
from
e4a61eb
to
84c5548
Compare
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
5 times, most recently
from
d8f0351
to
3962867
Compare
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
2 times, most recently
from
815353a
to
dd7c2c7
Compare
|
@stlankes Does rusty-demo with qemu and SMP (2 cores) work for you on macOS? |
This was referenced May 6, 2020
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
from
b25835d
to
387cd46
Compare
jschwe
changed the title
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
3 times, most recently
from
869f43b
to
8fbb54a
Compare
Previously some indents had 3 spaces
Test if libhermit-rs can run the demo defined in rusty-hermit. This currently only works for ubuntu
Something is going wrong on macos and windows with qemu and smp
jschwe
force-pushed
the
feature/test-rusty-hermit-demo
branch
from
b67b544
to
4ba6d4f
Compare
|
I will review it. Commit ea0df74 was the solution. |
|
👍 |
This was referenced May 18, 2020
stlankes
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
May 20, 2020
Run rusty-demo on qemu on all three systems. This PR basically ports the improvements from hermit-os/kernel#40 to this repo.
simonschoening
pushed a commit
to simonschoening/libhermit-rs
that referenced
this pull request
Aug 26, 2021
* CI: Reformat steps with 2 spaces as indent Previously some indents had 3 spaces * CI: Add Qemu demo tests on libhermit-rs commits * Test if libhermit-rs can run the demo defined in rusty-hermit. This currently only works for ubuntu * CI: Add Qemu Test on Windows and MacOS * CI: Add timeout for qemu smp steps Something is going wrong on macos and windows with qemu and smp * CI: Run CI for all pushes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: This PR is ready for review.
I think the rusty-hermit demo should be run here as a test. Right now we only check if PRs compile and do a quick cargo test. Checking if the rusty-hermit demo is able to run succesfully improves the testing situation.
Changes:
( SMP doesn't work consistently, but thats a different issue - Demo sometimes hangs on Laplace test with qemu and SMP hermit-rs#12issue solved with 3411470)Workaround build failing by using old nightly (see also Pipeline is broken with current rust nightly. hermit-rs#7This was fixed by disabling lto in rusty-hemit)