Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scheduler sharing safe #612

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Make scheduler sharing safe #612

merged 4 commits into from
Dec 9, 2022

Conversation

mkroening
Copy link
Member

Closes #606.

@mkroening
Only share SchedulerInput between cores
1f26a5d 
Feature gate scheduler inputs on SMP
@mkroening mkroening marked this pull request as ready for review December 5, 2022 16:24
stlankes
stlankes approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Dec 9, 2022
@bors @mkroening
Merge #612 #616
762fb52 
612: Make scheduler sharing safe r=stlankes a=mkroening

Closes #606.

616: Rework GDT (cont.) r=stlankes a=mkroening

Continuing #614.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@bors
Copy link
Contributor

bors bot commented Dec 9, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Dec 9, 2022

Build succeeded:

@bors bors bot merged commit 657e658 into hermit-os:master Dec 9, 2022
mkroening added a commit to mkroening/libhermit-rs that referenced this pull request Dec 9, 2022
@mkroening
Revert "Merge hermit-os#612"
66125a4 
This reverts commit 657e658, reversing
changes made to aa02266.
@mkroening mkroening deleted the scheduler-sync branch March 11, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes stlankes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

&PerCoreScheduler is shared between threads unsafely
2 participants
@mkroening @stlankes