Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite BumpAllocator (BootstrapAllocator) #629

Merged
merged 4 commits into from
Jan 8, 2023
Merged

Rewrite BumpAllocator (BootstrapAllocator) #629

merged 4 commits into from
Jan 8, 2023

Conversation

mkroening
Copy link
Member

No description provided.

@mkroening mkroening marked this pull request as ready for review December 18, 2022 14:34
jounathaen
jounathaen approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@jounathaen jounathaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally very nice. Some formal remarks from my side :-)

src/mm/allocator/bootstrap.rs Show resolved Hide resolved
src/mm/allocator/bootstrap.rs Show resolved Hide resolved
src/mm/allocator/bootstrap.rs Show resolved Hide resolved
src/mm/allocator/bootstrap.rs Show resolved Hide resolved
src/mm/allocator/bump.rs Show resolved Hide resolved
src/mm/allocator/bump.rs Show resolved Hide resolved
src/mm/allocator/bump.rs Show resolved Hide resolved
src/mm/allocator/bootstrap.rs Show resolved Hide resolved
src/mm/allocator/mod.rs Show resolved Hide resolved
@mkroening
Copy link
Member Author

@jounathaen, I addressed your comments.

@jounathaen
Copy link
Member

I'm happy with this. Very nice code! Let's see what the CI says about it...

@mkroening
Copy link
Member Author

I needed to format the docs. Fixed now.

@jounathaen
Copy link
Member

let's

bors r+

this

@bors
Copy link
Contributor

bors bot commented Jan 8, 2023

Build succeeded:

@bors bors bot merged commit 3a44a06 into hermit-os:master Jan 8, 2023
@mkroening mkroening deleted the bump branch January 9, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jounathaen jounathaen jounathaen approved these changes

@stlankes stlankes Awaiting requested review from stlankes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @jounathaen