Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide math.h from hermit-builtins #654

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Provide math.h from hermit-builtins #654

merged 2 commits into from
Feb 14, 2023

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Feb 12, 2023 •
edited

@mkroening mkroening changed the title builtins: Provide math Provide math.h from hermit-builtins Feb 12, 2023
@mkroening mkroening marked this pull request as ready for review February 12, 2023 22:33
@mkroening mkroening mentioned this pull request Feb 12, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 13, 2023
@Dylan-DPC
Rollup merge of rust-lang#107970 - hermitcore:hermit-rm-floor, r=thomcc
55f36ed 
Hermit: Remove floor symbol

This symbol should be provided by Hermit.

It was introduced in 2019 (rust-lang#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight.

Related:
* hermit-os/kernel#654
* hermit-os/hermit-rs#406

CC: `@stlankes`
@stlankes
Copy link
Contributor

I am little bit lost. Why do you move the math symbols?

@mkroening
Copy link
Member Author

bors r=stlankes

@bors
Copy link
Contributor

bors bot commented Feb 14, 2023

Build succeeded:

@bors bors bot merged commit ff52547 into master Feb 14, 2023
@bors bors bot deleted the builtin-math branch February 14, 2023 09:45
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request May 31, 2023
@Dylan-DPC
Rollup merge of #107970 - hermitcore:hermit-rm-floor, r=thomcc
2d51085 
Hermit: Remove floor symbol

This symbol should be provided by Hermit.

It was introduced in 2019 (rust-lang/rust#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight.

Related:
* hermit-os/kernel#654
* hermit-os/hermit-rs#406

CC: `@stlankes`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes Awaiting requested review from stlankes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @stlankes