-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert virtiofs driver to support the new virtqueue implementation #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Virtqueues are also modified to support unsized objects - the network driver is also modified to support the changes in the changes in the virtqueue implementation
because the current driver based on pci support
The size of unsized structs is often aligned to a 16 byte boundery. However, virtio requires on the exact size of the struct. Consequently, the trait AsSliceU8 is extended with the function `len` to determine the exact size.
mkroening
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
bors r+
mkroening
changed the title
convert virtio-fs driver to support the new virtqueue implementation
convert virtiofs driver to support the new virtqueue implementation
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the old virtio-fs driver and tested it with virtiofsd. The old version are written for the old virtio implementation. To test the interface, a local directory is mapped within the guest to /root. The demo application is able to create a file
foo.txt
and is also able to read the file (seecreate_file
inexamples/demo/src/tests/mod.rs
).Build demo:
Run following demo as root: