collect configuration of mmio devices #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
fc
branch
3 times, most recently
from
1b8fe72
to
7932411
Compare
Firecracker pass the configuration of all mmio device by a Linux kernel parameter
This parameter is defined as followd:
virtio_mmio.device=
[VMMIO] Memory mapped virtio (platform) device.
<size>@<baseaddr>:<irq>[:<id>]
where:
<size> := size (can use standard suffixes like K, M and G)
<baseaddr> := physical base address
<irq> := interrupt number (as passed to request_irq())
<id> := (optional) platform device id
example:
virtio_mmio.device=1K@0x100b0000:48:7
Can be used multiple times for multiple devices.
This patch parse the command line and store the string
<size>@<baseaddr>:<irq>[:<id>] in a vector, which is part of CLI.
This PR based on preliminary work of @duanyu-yu
Co-authored-by: Yu Duan <yu_duan@yahoo.com>
Firecracker parse the linux argument virtio_mmio.device to the kernel, which specifies the mmio addresses for VirtIO devices. This patch uses these arguments to find the network interface.wq:
This feature is not required. If VIRTIO_NET_F_STATUS is not announce, the driver assumes that the link is always active. This behavior is conform to the VirtIO standard.
mkroening
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firecracker pass the configuration of all mmio device by a Linux kernel parameter This parameter is defined as followd:
This patch parse the command line and store the string
<size>@<baseaddr>:<irq>[:<id>]in a vector, which is part of CLI. The vector is used to find the network device on a microVM.In addition, the network driver support devices, which doesn't support VIRTIO_NET_F_STATUS.
This PR based on preliminary work from @duanyu-yu