Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Error variants #137

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Remove unused Error variants #137

merged 1 commit into from
Jul 13, 2021

Conversation

mkroening
Copy link
Member

No description provided.

@mkroening mkroening requested a review from stlankes July 11, 2021 17:29
@mkroening mkroening self-assigned this Jul 11, 2021
@mkroening mkroening force-pushed the error branch 2 times, most recently from 10d29ca to f0da8a7 Compare July 11, 2021 17:56
@mkroening mkroening mentioned this pull request Jul 11, 2021
Merged
@mkroening
Copy link
Member Author

Rebased on latest master.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #137 (83e5268) into master (7951d0f) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   33.56%   33.65%   +0.09%     
==========================================
  Files          17       17              
  Lines        3954     3943      -11     
==========================================
  Hits         1327     1327              
+ Misses       2627     2616      -11
Impacted Files Coverage Δ
src/error.rs 16.66% <0.00%> (+5.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7951d0f...83e5268. Read the comment docs.

stlankes
stlankes approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

Build succeeded:

@bors bors bot merged commit 295ddc3 into hermit-os:master Jul 13, 2021
@mkroening mkroening deleted the error branch July 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes stlankes approved these changes

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @stlankes