CI: Download Git-LFS files #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2021
195: Integration tests: Use default profile r=stlankes a=mkroening For easy integration tests of gdbstub, I need the `dev ` `opt-level` to be 0. On `release`, `opt-level` is 3 by default. 197: CI: Download Git-LFS files r=stlankes a=mkroening This is required for the [`test_vm.*`](https://github.com/hermitcore/uhyve/blob/3b70087e3612e55ddce7888ce1b9fe91ca8596c9/src/vm.rs#L856-L907) to work correctly. Without this, they are not operating on the real files, but mere placeholders. We need `git-lfs` to be installed on our runner for this. Found via #192. 200: CI: Capture test output r=stlankes a=mkroening This avoids GitHub check annotations about expected panics. This reverts 4e222b7. Co-authored-by: Martin Kröning <mkroening@posteo.net>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2021
197: CI: Download Git-LFS files r=stlankes a=mkroening This is required for the [`test_vm.*`](https://github.com/hermitcore/uhyve/blob/3b70087e3612e55ddce7888ce1b9fe91ca8596c9/src/vm.rs#L856-L907) to work correctly. Without this, they are not operating on the real files, but mere placeholders. We need `git-lfs` to be installed on our runner for this. Found via #192. 200: CI: Capture test output r=stlankes a=mkroening This avoids GitHub check annotations about expected panics. This reverts 4e222b7. Co-authored-by: Martin Kröning <mkroening@posteo.net>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2021
197: CI: Download Git-LFS files r=stlankes a=mkroening This is required for the [`test_vm.*`](https://github.com/hermitcore/uhyve/blob/3b70087e3612e55ddce7888ce1b9fe91ca8596c9/src/vm.rs#L856-L907) to work correctly. Without this, they are not operating on the real files, but mere placeholders. We need `git-lfs` to be installed on our runner for this. Found via #192. Co-authored-by: Martin Kröning <mkroening@posteo.net>
|
Build failed: |
|
bors retry |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for the
test_vm.*to work correctly. Without this, they are not operating on the real files, but mere placeholders.We need
git-lfsto be installed on our runner for this.Found via #192.