-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettyfied use statements in the whole project #451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 16 16
Lines 2206 2206
=======================================
Hits 1400 1400
Misses 806 806
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in an automated fashion.
I did something similar for libhermit-rs: hermit-os/kernel@d2e6c6d
@stlankes and I agreed to set imports_granularity
to Module
. You seem to prefer setting it to Crate
. What do you think?
Ah, these features require nightly rustfmt. So for the format CI we would use: - uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt |
Yeah, adding it to rustfmt is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, these features require nightly rustfmt. So for the format CI we would use:
- uses: dtolnay/rust-toolchain@stable with: components: rustfmt
Without this, CI silently does not check for correct formatting.
Also, could you squash everything? :)
c581a42
to
30544d7
Compare
Stable? - Not nightly? |
Honestly, I'd suggest not to include a nightly CI check here, but simply wait until that feature is stabilized. It is a very minor thing and if a few use statements are off, that's not a big deal. |
bors r+ |
Build succeeded: |
No description provided.