Arm refactor #657
Merged
Arm refactor #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jounathaen
force-pushed
the
big_refactor
branch
from
b23fab7
to
ac4c0ba
Compare
jounathaen
force-pushed
the
arm_refactor
branch
from
a199861
to
64f75c6
Compare
jounathaen
force-pushed
the
big_refactor
branch
from
ac4c0ba
to
2761121
Compare
jounathaen
force-pushed
the
arm_refactor
branch
from
5974a26
to
608e866
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## big_refactor #657 +/- ##
================================================
+ Coverage 67.65% 67.79% +0.13%
================================================
Files 19 20 +1
Lines 2328 2338 +10
================================================
+ Hits 1575 1585 +10
Misses 753 753 ☔ View full report in Codecov by Sentry. |
jounathaen
force-pushed
the
arm_refactor
branch
from
608e866
to
1772fa9
Compare
mkroening
requested changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more or less fixes aarch64 issues introduced by #527 .
Note: This is not tested, as I don't have an aarch64 machine available.
Somewhat fixes #641