Fixing the allInstances primitive to take permSpace objects

hernanmd · Feb 3, 2023 · 5970390 · 5970390
1 parent 2484e2b
commit 5970390
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/smalltalksrc/VMMaker/SpurMemoryManager.class.st b/smalltalksrc/VMMaker/SpurMemoryManager.class.st
@@ -1437,7 +1437,10 @@ SpurMemoryManager >> allHeapEntitiesDo: aBlock [
 	"N.B. e.g. allObjects relies on the old/new order here."
 
 	self allOldSpaceEntitiesDo: aBlock.
-	self allNewSpaceEntitiesDo: aBlock
+	self allNewSpaceEntitiesDo: aBlock.
+
+	"In PermSpace we only have objects, so directly iterate them"
+	self allPermSpaceObjectsDo: aBlock
 ]
 
 { #category : #'primitive support' }

diff --git a/smalltalksrc/VMMakerTests/VMPermanentSpaceMemoryTest.class.st b/smalltalksrc/VMMakerTests/VMPermanentSpaceMemoryTest.class.st
@@ -12,6 +12,19 @@ VMPermanentSpaceMemoryTest >> setUp [
 	self createWeakArrayClass
 ]
 
+{ #category : #'tests - allocation' }
+VMPermanentSpaceMemoryTest >> testAllInstancesReturnsObjectsInPermSpace [
+
+	| permanentObject allInstances |
+
+	permanentObject := self newPermanentByteObjectOfSize: 14.
+
+	allInstances := memory allInstancesOf: memory classByteArray.
+
+	self assert: (memory slotSizeOf: allInstances) equals: 1.
+	self assert: (memory fetchPointer: 0 ofObject: allInstances) equals: permanentObject.
+]
+
 { #category : #'test - moving' }
 VMPermanentSpaceMemoryTest >> testCompiledMethodWithMachineCodeIsNotRememberedWhenModified [