Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot is not consistent for import function #15

Open
hernpiblo opened this issue Nov 12, 2021 · 1 comment
Open

Screenshot is not consistent for import function #15

hernpiblo opened this issue Nov 12, 2021 · 1 comment

Comments

@hernpiblo
Copy link
Owner

hernpiblo commented Nov 12, 2021

image.png

image.png

Capitalise first letter or not? "Room" or "Room Number"? "Phone" or "Phone Number"?

This will be troublesome for user to debug since it requires them to test out different variations manually in their csv file

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2021

Team's Response

As mentioned in the previous line, the first line is discarded. So it doesn't matter what it contains. ie, capitalization nor the content of the first row matters.

This is implemented as such since it's very likely the residence admin has an excel sheet, which when exported to csv will contain the column headings. So by not restricting the names, we provide greater flexibility.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement:
image.png

There was no mention that the values in the first row can differ from the given example, furthermore, it is explicitly stated that the values have to follow a certain order so readers will be confused as to which to follow.

Just because the UG mentioned that the first row will be discarded does not imply that the values can be different from what is shown


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants