Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to custom sorting in storage index search #142

Merged
merged 3 commits into from May 23, 2024
Merged

Add support to custom sorting in storage index search #142

merged 3 commits into from May 23, 2024

Conversation

ftkg
Copy link
Contributor

@ftkg ftkg commented Mar 8, 2024

No description provided.

@ftkg ftkg mentioned this pull request Mar 8, 2024
Merged
sesposito
sesposito requested changes May 8, 2024
View reviewed changes
Copy link
Member

@sesposito sesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nit. We should also update the changelog.

index.d.ts Outdated Show resolved Hide resolved
ftkg and others added 2 commits May 15, 2024 10:04
@ftkg
add sortable and order params
5744281
@ftkg @sesposito
Make order param optional
38b8330 
Co-authored-by: Simon Esposito <simon@heroiclabs.com>
@ftkg ftkg force-pushed the ft-storage-index-custom-sort branch from b511031 to 38b8330 Compare May 15, 2024 13:05
@ftkg ftkg requested a review from sesposito May 15, 2024 13:42
@ftkg ftkg merged commit 752591b into master May 23, 2024
2 checks passed
@ftkg ftkg deleted the ft-storage-index-custom-sort branch May 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesposito sesposito sesposito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ftkg @sesposito