Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'ReceivedSessionUpdated' when session expires and is refreshed. #169

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

novabyte
Copy link
Member

@novabyte novabyte commented Mar 3, 2024

No description provided.

@novabyte novabyte requested a review from lugehorsam March 3, 2024 11:01
@@ -54,6 +54,15 @@ public interface IClient
/// </summary>
string ServerKey { get; }

/// <summary>
/// Received a new session after the current one had expired.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@novabyte I think this event will still fire even if SessionRefreshAsync is manually invoked by the user, regardless of whether autoRefreshSession is enabled or the current session had expired. I think that's fine but then this comment and remark would need to be adjusted.

@novabyte novabyte merged commit e2391f2 into master Mar 5, 2024
1 of 2 checks passed
@novabyte novabyte deleted the cdm-session-refreshed-event branch March 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants