Skip to content

Commit

Permalink
fix internal import and enum name, update changelog (#106)
Browse files Browse the repository at this point in the history
  • Loading branch information
lugehorsam committed Oct 11, 2023
1 parent 78857a3 commit 7517535
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 7 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project are documented below.
The format is based on [keep a changelog](http://keepachangelog.com/) and this project uses [semantic versioning](http://semver.org/).
### Unreleased

### [2.9.1] - 2023-10-11
### Fixed
- Fix support for non-ASCII characters in session authentication tokens.
- Fixed an internal import and enum name that could cause compilation failures depending on the project's build flags.

### [2.9.0] - 2023-10-04
### Added
- Added `TFunction` support to our API calls for more concise use of callbacks.
Expand Down
2 changes: 1 addition & 1 deletion Nakama/Nakama.uplugin
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"FileVersion": 3,
"Version": 2400,
"VersionName": "2.9.0",
"VersionName": "2.9.1",
"FriendlyName": "Nakama client",
"Description": "A UE4 and UE5 client for the Nakama server.",
"Category": "HeroicLabs.Nakama",
Expand Down
8 changes: 4 additions & 4 deletions Nakama/Source/NakamaUnreal/Private/NakamaClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5270,7 +5270,7 @@ void UNakamaClient::DeleteFriends(
}

// Make the request
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DELETE, QueryParams, Session->GetAuthToken());
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DEL, QueryParams, Session->GetAuthToken());

// Lock the ActiveRequests mutex to protect concurrent access
FScopeLock Lock(&ActiveRequestsMutex);
Expand Down Expand Up @@ -5654,7 +5654,7 @@ void UNakamaClient::DeleteGroup(
}

// Make the request
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DELETE, TMultiMap<FString, FString>(), Session->SessionData.AuthToken);
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DEL, TMultiMap<FString, FString>(), Session->SessionData.AuthToken);

// Lock the ActiveRequests mutex to protect concurrent access
FScopeLock Lock(&ActiveRequestsMutex);
Expand Down Expand Up @@ -6990,7 +6990,7 @@ void UNakamaClient::DeleteLeaderboardRecord(UNakamaSession* Session,
}

// Make the request
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DELETE, TMultiMap<FString, FString>(), Session->GetAuthToken());
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DEL, TMultiMap<FString, FString>(), Session->GetAuthToken());

// Lock the ActiveRequests mutex to protect concurrent access
FScopeLock Lock(&ActiveRequestsMutex);
Expand Down Expand Up @@ -7284,7 +7284,7 @@ void UNakamaClient::DeleteNotifications(
}

// Make the request
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DELETE, QueryParams, Session->GetAuthToken());
const auto HttpRequest = MakeRequest(Endpoint, TEXT(""), ENakamaRequestMethod::DEL, QueryParams, Session->GetAuthToken());

// Lock the ActiveRequests mutex to protect concurrent access
FScopeLock Lock(&ActiveRequestsMutex);
Expand Down
2 changes: 1 addition & 1 deletion Nakama/Source/NakamaUnreal/Public/NakamaClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ enum class ENakamaRequestMethod : uint8
{
GET,
POST,
DELETE,
DEL,
PUT,
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "CoreMinimal.h"
#include "NakamaRtError.h"
//#include "NakamaUtils.h"
#include "Serialization/JsonSerializer.h"
#include "UObject/NoExportTypes.h"
#include "NakamaRealtimeRequestContext.generated.h"

Expand Down
2 changes: 1 addition & 1 deletion Nakama/Source/NakamaUnreal/Public/NakamaUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class FNakamaUtils
return TEXT("POST");
case ENakamaRequestMethod::PUT:
return TEXT("PUT");
case ENakamaRequestMethod::DELETE:
case ENakamaRequestMethod::DEL:
return TEXT("DELETE");
default:
// Handle unrecognized verb if needed
Expand Down

0 comments on commit 7517535

Please sign in to comment.