ExecuteInTx PostgreSQL version #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ExecuteInTx accepted open transaction, but required users never to execute any commands on it prior to calling ExecuteInTx. This API change enforces this contract by making ExecuteInTx to open transaction internally and pass it to the callback func.
redbaron
force-pushed
the
execute-in-tx-pg-skip
branch
from
ede550b
to
2223bc0
Compare
ftkg
requested changes
Jul 10, 2023
redbaron
force-pushed
the
execute-in-tx-pg-skip
branch
from
2223bc0
to
8e20c5e
Compare
…e Server PostgreSQL doesn't benefit from SAVEPOINT/ROLLBACK logic like CockroachDB does. With this change Nakama checks server DB engine and enables CockroachDB optimization only when necessary. There are 2 behviour change in the PG version of ExecuteInTx: - it retries on all "Class 40" (a.k.a retriable) codes, not just serialization error: 40000 transaction_rollback 40002 transaction_integrity_constraint_violation 40001 serialization_failure 40003 statement_completion_unknown 40P01 deadlock_detected - It doesn't ignore COMMIT result code anymore
redbaron
force-pushed
the
execute-in-tx-pg-skip
branch
from
8e20c5e
to
b8c8707
Compare
ftkg
approved these changes
Jul 11, 2023
zyro
requested changes
Jul 11, 2023
zyro
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve ExecuteInTx in following ways:
Previously it required call-site to provide
Tx, but imposed restriction that caller must open, but don't useTxprior to calling ExecuteInTx. This change now enforces this contract by creatingTxinternally, caller provides*sql.DBinstead.ExecuteInTx was optimized for CockroachDB. Every transaction in addition to standard
BEGIN/COMMIThadSAVEPOINTandRELEASE SAVEPOINTcommands as the very first and very last commands in transaction. These are unnecessary in PG and add 2 additional round-trips to the database. For small and quick inserts additional round-trips are comparable to the query itself. There is now separate version ofExecuteInTxfor Cockroach and regular PosgreSQL. CockroachDB version is enabled at connection time based on result fromversion()SQL function.ExecuteInTx used to ignore
COMMIToperation result. It wasn't a problem with CockroachDB, because commit actually happened onRELEASE SAVEPOINTandCOMMITcouldn't fail. On PostgreSQLCOMMITcan fail and ignoring possible errors is undesirable.