Add storage index create indexOnly flag #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syhpoon
reviewed
Sep 6, 2023
go.mod
Outdated
| @@ -81,3 +81,5 @@ require ( | |||
| google.golang.org/genproto v0.0.0-20230530153820-e85fd2cbaebc // indirect | |||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230530153820-e85fd2cbaebc // indirect | |||
| ) | |||
|
|
|||
| replace github.com/heroiclabs/nakama-common => ../nakama-common | |||
There was a problem hiding this comment.
hm, I assume it's a leftover from local development?
There was a problem hiding this comment.
Yep, it's intentional as we'll wait for the corresponding nakama-common changes to be merged and then point go.mod to that commit and rebase.
sesposito
force-pushed
the
spe/add-storage-index-only
branch
from
adecd40
to
e0204d4
Compare
syhpoon
approved these changes
Sep 7, 2023
sesposito
force-pushed
the
spe/add-storage-index-only
branch
from
33988f4
to
b81de3a
Compare
sesposito
force-pushed
the
spe/add-storage-index-only
branch
from
4c16728
to
ea65dbd
Compare
zyro
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add storage object create and update times in storage write acks.
nakama-common changes PR: heroiclabs/nakama-common#130