Use basic auth in metadata check for console authentication #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a change I needed to make on the frontend. Will reopen shortly. |
|
Ready for review. |
|
Putting a reminder here to myself to think about how this change to the console API will affect any current GUIs that our clients have built on top of the Console API. |
|
Closing this PR because @zyro and I talked through a way to modify the code generator that makes a lot of sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlines the authentication process for the Console API. By doing an initial authentication via headers/metadata, the Console SDK code generators can properly emit the
Authenticatemethod by reading theBasicAuthsecurity option in Console Swagger doc.Closes #440