Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console user/login fixes #978

Merged
merged 4 commits into from Jan 25, 2023
Merged

Console user/login fixes #978

merged 4 commits into from Jan 25, 2023

Conversation

ftkg
Copy link
Contributor

@ftkg ftkg commented Jan 24, 2023

  • Enforce minimum password length to 8
  • Transform both username and email to lowercase to avoid duplicates
  • Hash password on user not found to maintain equal response times on all cases

@zyro zyro merged commit ada6f94 into master Jan 25, 2023
@zyro zyro deleted the ft-console-login-fixes branch January 25, 2023 17:17
deflinhec added a commit to deflinhec/nakama that referenced this pull request Mar 30, 2023
@deflinhec
Merge branch 'master' into ft-angular-15
72ae2ab 
* master: (27 commits)
  Satori API integration fixes (heroiclabs#1005)
  Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997)
  manually revert protobufany and updategroup in swagger.json (heroiclabs#1003)
  Make haystack cursors consistent with listing (heroiclabs#994)
  Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992)
  Add runtimes satori integration (heroiclabs#993)
  Disconnect banned users (heroiclabs#1001)
  Add runtime http insecure flag (heroiclabs#1002)
  Add Go runtime GroupUpdate userID param (heroiclabs#996)
  Better handling of matchmaker operations while the interval process is running.
  Ensure direct message channel message listing is correctly scoped to participants only.
  Update get purchase/subscription signature (heroiclabs#990)
  Fix reversal of open/closed group listing filter (heroiclabs#989)
  Always log out a deleted user (heroiclabs#987)
  Listing returned vars (heroiclabs#986)
  Add tournament record delete runtime functions. (heroiclabs#977)
  Improve google refund polling handling. (heroiclabs#982)
  Console user and authentication improvements. (heroiclabs#978)
  Console session handling improvements. (heroiclabs#979)
  Fix google purchase upsert query. (heroiclabs#973)
  ...

# Conflicts:
#	console/ui/dist/prod-nt/index.html
#	console/ui/dist/prod/index.html
deflinhec added a commit to deflinhec/nakama that referenced this pull request Mar 30, 2023
@deflinhec
Merge branch 'master' into ft-angular-15
37c6945 
* master: (27 commits)
  Satori API integration fixes (heroiclabs#1005)
  Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997)
  manually revert protobufany and updategroup in swagger.json (heroiclabs#1003)
  Make haystack cursors consistent with listing (heroiclabs#994)
  Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992)
  Add runtimes satori integration (heroiclabs#993)
  Disconnect banned users (heroiclabs#1001)
  Add runtime http insecure flag (heroiclabs#1002)
  Add Go runtime GroupUpdate userID param (heroiclabs#996)
  Better handling of matchmaker operations while the interval process is running.
  Ensure direct message channel message listing is correctly scoped to participants only.
  Update get purchase/subscription signature (heroiclabs#990)
  Fix reversal of open/closed group listing filter (heroiclabs#989)
  Always log out a deleted user (heroiclabs#987)
  Listing returned vars (heroiclabs#986)
  Add tournament record delete runtime functions. (heroiclabs#977)
  Improve google refund polling handling. (heroiclabs#982)
  Console user and authentication improvements. (heroiclabs#978)
  Console session handling improvements. (heroiclabs#979)
  Fix google purchase upsert query. (heroiclabs#973)
  ...

# Conflicts:
#	console/ui/dist/prod-nt/index.html
#	console/ui/dist/prod/index.html
deflinhec added a commit to deflinhec/nakama that referenced this pull request Mar 30, 2023
@deflinhec
Merge branch 'master' into ft-lua-hot-reload
0144a6f 
* master: (27 commits)
  Satori API integration fixes (heroiclabs#1005)
  Attempt to exchange Google's authorization code when given one instead of as a JWT (heroiclabs#997)
  manually revert protobufany and updategroup in swagger.json (heroiclabs#1003)
  Make haystack cursors consistent with listing (heroiclabs#994)
  Support purchases-not-null-uid.sql migration on crdb. (heroiclabs#992)
  Add runtimes satori integration (heroiclabs#993)
  Disconnect banned users (heroiclabs#1001)
  Add runtime http insecure flag (heroiclabs#1002)
  Add Go runtime GroupUpdate userID param (heroiclabs#996)
  Better handling of matchmaker operations while the interval process is running.
  Ensure direct message channel message listing is correctly scoped to participants only.
  Update get purchase/subscription signature (heroiclabs#990)
  Fix reversal of open/closed group listing filter (heroiclabs#989)
  Always log out a deleted user (heroiclabs#987)
  Listing returned vars (heroiclabs#986)
  Add tournament record delete runtime functions. (heroiclabs#977)
  Improve google refund polling handling. (heroiclabs#982)
  Console user and authentication improvements. (heroiclabs#978)
  Console session handling improvements. (heroiclabs#979)
  Fix google purchase upsert query. (heroiclabs#973)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyro zyro zyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ftkg @zyro