Merge pull request SDWebImage#1076 from ikesyo/faild-urls-nsset

[Refactor] Use NSMutableSet for failed URLs' storage instead of array
heroims · Mar 18, 2015 · 27e3038 · 27e3038
2 parents d41bfaf + 210c13d
commit 27e3038
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m
@@ -21,7 +21,7 @@ @interface SDWebImageManager ()
 
 @property (strong, nonatomic, readwrite) SDImageCache *imageCache;
 @property (strong, nonatomic, readwrite) SDWebImageDownloader *imageDownloader;
-@property (strong, nonatomic) NSMutableArray *failedURLs;
+@property (strong, nonatomic) NSMutableSet *failedURLs;
 @property (strong, nonatomic) NSMutableArray *runningOperations;
 
 @end
@@ -41,7 +41,7 @@ - (id)init {
     if ((self = [super init])) {
         _imageCache = [self createCache];
         _imageDownloader = [SDWebImageDownloader sharedDownloader];
-        _failedURLs = [NSMutableArray new];
+        _failedURLs = [NSMutableSet new];
         _runningOperations = [NSMutableArray new];
     }
     return self;
@@ -194,9 +194,7 @@ - (void)diskImageExistsForURL:(NSURL *)url
 
                     if (error.code != NSURLErrorNotConnectedToInternet && error.code != NSURLErrorCancelled && error.code != NSURLErrorTimedOut) {
                         @synchronized (self.failedURLs) {
-                            if (![self.failedURLs containsObject:url]) {
-                                [self.failedURLs addObject:url];
-                            }
+                            [self.failedURLs addObject:url];
                         }
                     }
                 }