refactor message type logic

heroku-examples · Oct 8, 2013 · 0c16c6f · 0c16c6f
1 parent ac506f3
commit 0c16c6f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/models/ChatRoom.java b/app/models/ChatRoom.java
@@ -273,17 +273,18 @@ public void onMessage(String channel, String messageBody) {
 			//Process messages from the pub/sub channel
 	    	JsonNode parsedMessage = Json.parse(messageBody);
 	    	Object message = null;
-	    	if("talk".equals(parsedMessage.get("type").asText())) {	    		
+	    	String messageType = parsedMessage.get("type").asText();
+	    	if("talk".equals(messageType)) {	    		
 	    		message = new Talk(
 	    				parsedMessage.get("username").asText(), 
 	    				parsedMessage.get("text").asText()
 	    				);
-	    	} else if("rosterNotify".equals(parsedMessage.get("type").asText())) {	
+	    	} else if("rosterNotify".equals(messageType)) {	
 	    		message = new RosterNotification(
 	    				parsedMessage.get("username").asText(),
 	    				parsedMessage.get("direction").asText()
 	    				);
-	    	} else if("quit".equals(parsedMessage.get("type").asText())) {	
+	    	} else if("quit".equals(messageType)) {	
 	    		message = new Quit(
 	    				parsedMessage.get("username").asText() 
 	    				);