Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase some sentences in Korean version of intro.md #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kimjson
Copy link

@kimjson kimjson commented Jan 7, 2022

Please to refer to the commit messages I wrote for detailed description and nationale of the changes.

* 'Declarative' is defined as "denoting high-level programming languages which can be used to solve problems **without requiring the programmer to specify an exact procedure** to be followed". Therefore it's better not to translate it as '절차' which means 'procedure' in Korean.
* Though '선언적인 (declarative in Korean)' is not a very self-explanatory word to many native Korean readers, I couldn't found better alternative. So I linked that text to Korean Wikipedia article explaining 'declarative programming'
* Since it's too bold to say twelve-factor app cannot make server and system administration needless(필요없게). So I replaced it with less affirmative word '줄이다' which better matches with 'obviate'
* It's not very common for Koreans to use the word 'agility' in this context, so I provided context by adding some omitted phrases('agility to requirement changes' in Korean).
* Replaced words which aren't actually translated into "Korean" but just rewritten, such as 툴 (tooling), 아키텍처 (architecture)
Copy link

@astralhpi astralhpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Korean translation has become much more natural.

@kimjson kimjson changed the title Rephrase some sentence in Korean version of intro.md Rephrase some sentences in Korean version of intro.md Jan 7, 2022
@kimjson
Copy link
Author

kimjson commented Jan 7, 2022

Korean translation has become much more natural.

빠른 검토 감사합니다. 메인테이너 통해서 정식으로 리뷰 요청드리려고 했는데 그만 직접 멘션을 때려버렸네요

@kimjson
Copy link
Author

kimjson commented Jan 8, 2022

@davidrouten can you review this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants