This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Continue to overwrite the bill as long as it's Estimated #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we mark a bill as "finalized" when a new month's bill
appears in S3, but AWS continues to update a bill after a month is
over for several days. The correct way to check for a "finalized" bill
is to see whether the invoice_id row has a number or is marked as
"Estimated". As long as the bill is estimated, we want to overwrite it
with new data.
We can't do this earlier on because that would require peeking at the
S3 data, so overwrite the data in the line_items table as long as it's
not a finalized bill.
Finally, some rows appear in the spreadsheet for a given month as
"totals" of the other rows. These rows do not have an invoice_id (it's
empty) hence the check for '' below.