Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move supplementary code into its own crate #200

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Move supplementary code into its own crate #200

merged 5 commits into from
Jan 4, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Jan 3, 2024

This buildpack is currently shipping the inventory management binaries (which are intended for use by GitHub Actions automation only) as part of the published buildpack:

$ docker run --rm -it heroku/builder:22 bash -c 'ls /cnb/buildpacks/heroku_go/*/.libcnb-cargo/additional-bin/'

diff_inventory   update_inventory

This is because currently libcnb-package packages all binaries in the buildpack crate.

This PR moves the inventory management binaries to their own crate, so that these binaries aren't unintentionally included.

Since this PR brings in cargo workspace functionality, it also meant that the buildpack source has changed locations. It's now in ./buildpacks/go, which matches the directory structure of other buildpacks like https://github.com/heroku/buildpacks-nodejs, https://github.com/heroku/buildpacks-ruby, and https://github.com/heroku/buildpacks-jvm.

@joshwlewis joshwlewis marked this pull request as ready for review January 3, 2024 17:51
@joshwlewis joshwlewis requested a review from a team as a code owner January 3, 2024 17:51
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@joshwlewis joshwlewis merged commit 1a93d08 into main Jan 4, 2024
4 checks passed
@joshwlewis joshwlewis deleted the multi-crate branch January 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants