Update to libcnb 0.14.0 #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates libcnb related crates from 0.13.0 to 0.14.0: https://github.com/heroku/libcnb.rs/releases/tag/v0.14.0 Dependabot didn't open a PR since it appears to have issues with Cargo workspace root dependencies when using the beta dependency grouping feature. I've also updated the `nodejs-corepack` integration tests to use the improved `run_shell_command` helper - which is a much better fit for running one off commands. (This helper existed before, but as of libcnb 0.14.0 now offers even more advantages, since it's able to validate exit code.) GUS-W-13976470.
|
Quite a reduction in transitive dependencies ( |
Malax
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Looks good to me, leaving final word about this to @joshwlewis - but probably not a controversial PR :)
joshwlewis
approved these changes
Aug 21, 2023
colincasey
added a commit
that referenced
this pull request
Sep 7, 2023
* main: Bump chrono from 0.4.26 to 0.4.28 (#642) Bump serde from 1.0.183 to 1.0.188 (#643) Bump url from 2.4.0 to 2.4.1 (#644) Bump regex from 1.9.3 to 1.9.4 (#645) Skip `mirror-distribution` job if there are no versions (#628) Bump Swatinem/rust-cache from 2.5.1 to 2.6.2 (#640) Update to libcnb 0.14.0 (#638) Update Procfile CNB to v2.0.1 (#639) Bump buildpacks/github-actions from 5.3.0 to 5.4.0 (#636) Bump regex from 1.9.1 to 1.9.3 (#635) Bump serde_json from 1.0.104 to 1.0.105 (#634) Bump thiserror from 1.0.44 to 1.0.47 (#633) Bump toml from 0.7.5 to 0.7.6 (#632) Bump anyhow from 1.0.71 to 1.0.75 (#631) Bump tempfile from 3.7.0 to 3.7.1 (#630) Bump serde from 1.0.166 to 1.0.168 (#629) Ignore yarn 2.4.3 (#627) Fix inventory update order (#621) # Conflicts: # Cargo.lock # Cargo.toml # test_support/src/lib.rs
colincasey
added a commit
that referenced
this pull request
Sep 7, 2023
* main: Bump chrono from 0.4.26 to 0.4.28 (#642) Bump serde from 1.0.183 to 1.0.188 (#643) Bump url from 2.4.0 to 2.4.1 (#644) Bump regex from 1.9.3 to 1.9.4 (#645) Skip `mirror-distribution` job if there are no versions (#628) Bump Swatinem/rust-cache from 2.5.1 to 2.6.2 (#640) Update to libcnb 0.14.0 (#638) Update Procfile CNB to v2.0.1 (#639) Bump buildpacks/github-actions from 5.3.0 to 5.4.0 (#636) Bump regex from 1.9.1 to 1.9.3 (#635) Bump serde_json from 1.0.104 to 1.0.105 (#634) Bump thiserror from 1.0.44 to 1.0.47 (#633) Bump toml from 0.7.5 to 0.7.6 (#632) Bump anyhow from 1.0.71 to 1.0.75 (#631) Bump tempfile from 3.7.0 to 3.7.1 (#630) Bump serde from 1.0.166 to 1.0.168 (#629) Ignore yarn 2.4.3 (#627) Fix inventory update order (#621) # Conflicts: # Cargo.lock # Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates libcnb related crates from 0.13.0 to 0.14.0:
https://github.com/heroku/libcnb.rs/releases/tag/v0.14.0
Dependabot didn't open a PR since it appears to have issues with Cargo workspace root dependencies when using the beta dependency grouping feature. (I'll report this upstream shortly)
I've also updated the
nodejs-corepackintegration tests to use the improvedrun_shell_commandhelper - which is a much better fit for running one off commands. (This helper existed before, but as of libcnb 0.14.0 now offers even more advantages, since it's able to validate exit code.)GUS-W-13976470.