Skip to content

Commit

Permalink
chore(apps:info): Remove deprecation warning (#1671)
Browse files Browse the repository at this point in the history
This should have been removed long time ago, when [I added this warning](8c4ed7e), but never came back to this: .

Thank you to @BigAlUK for raising this issue in [Slack](https://heroku.slack.com/archives/C012K4TFP61/p1604075283179500)
  • Loading branch information
Raúl Barroso committed Nov 10, 2020
1 parent c8945bc commit 775c679
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions packages/apps-v5/src/commands/apps/info.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ function * run (context, heroku) {
}),
dynos: heroku.get(`/apps/${app}/dynos`).catch(() => []),
collaborators: heroku.get(`/apps/${app}/collaborators`).catch(() => []),
pipeline_coupling: pipelineCouplings,
pipeline: pipelineCouplings // TODO: Remove this key once we feel comfortable with https://github.com/heroku/heroku-apps/pull/207#issuecomment-335775852.
pipeline_coupling: pipelineCouplings
}

if (context.flags.extended) {
Expand Down Expand Up @@ -117,7 +116,6 @@ function * run (context, heroku) {
shell()
} else if (context.flags.json) {
cli.styledJSON(info)
cli.warn('DEPRECATION WARNING: `pipeline` key will be removed in favor of `pipeline_coupling`')
} else {
print()
}
Expand Down
2 changes: 0 additions & 2 deletions packages/apps-v5/test/commands/apps/info.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ stack=cedar-14
.get('/apps/myapp/collaborators').reply(200, collaborators)
.get('/apps/myapp/dynos').reply(200, [{ type: 'web', size: 'Standard-1X', quantity: 2 }])
return cmd.run({ args: { app: 'myapp' }, flags: { json: true, extended: true } })
.then(() => expect(unwrap(cli.stderr)).to.equal('DEPRECATION WARNING: `pipeline` key will be removed in favor of `pipeline_coupling`\n'))
.then(() => {
let json = JSON.parse(cli.stdout)
expect(json.appExtended).to.equal(undefined)
Expand All @@ -254,7 +253,6 @@ stack=cedar-14
.get('/apps/myapp/dynos').reply(200, [{ type: 'web', size: 'Standard-1X', quantity: 2 }])
.get('/apps/myapp/pipeline-couplings').reply(200, { app: { id: appAcm.id }, pipeline: { name: 'my-pipeline' } })
return cmd.run({ args: { app: 'myapp' }, flags: { json: true } })
.then(() => expect(unwrap(cli.stderr)).to.equal('DEPRECATION WARNING: `pipeline` key will be removed in favor of `pipeline_coupling`\n'))
.then(() => {
let json = JSON.parse(cli.stdout)
expect(json.appExtended).to.equal(undefined)
Expand Down

0 comments on commit 775c679

Please sign in to comment.