Skip to content

Commit

Permalink
chore: use https when possible (#1498)
Browse files Browse the repository at this point in the history
  • Loading branch information
XhmikosR committed May 11, 2020
1 parent 6a77f5a commit d54c394
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -13,5 +13,5 @@ Examples:
`chore(cli): edit README`
Learn more about [Conventional Commits](http://conventionalcommits.org).
Learn more about [Conventional Commits](https://www.conventionalcommits.org/).
-->
4 changes: 2 additions & 2 deletions packages/ci-v5/.gitignore
Expand Up @@ -18,13 +18,13 @@ coverage
# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
Expand Down
4 changes: 2 additions & 2 deletions packages/ci-v5/CHANGELOG.md
Expand Up @@ -469,8 +469,8 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
Change Log
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).
The format is based on [Keep a Changelog](https://keepachangelog.com/)
and this project adheres to [Semantic Versioning](https://semver.org/).

## Unreleased

Expand Down
4 changes: 2 additions & 2 deletions packages/git/src/git.ts
Expand Up @@ -15,7 +15,7 @@ export default class Git {
return stdout.trim()
} catch (error) {
if (error.code === 'ENOENT') {
ux.error('Git must be installed to use the Heroku CLI. See instructions here: http://git-scm.com')
ux.error('Git must be installed to use the Heroku CLI. See instructions here: https://git-scm.com')
}
throw error
}
Expand All @@ -27,7 +27,7 @@ export default class Git {
const s = cp.spawn('git', args, {stdio: [0, 1, 2]})
s.on('error', (err: Error & {code?: string}) => {
if (err.code === 'ENOENT') {
ux.error('Git must be installed to use the Heroku CLI. See instructions here: http://git-scm.com')
ux.error('Git must be installed to use the Heroku CLI. See instructions here: https://git-scm.com')
} else reject(err)
})
s.on('close', resolve)
Expand Down
4 changes: 2 additions & 2 deletions packages/git/test/lib/git.js
Expand Up @@ -29,7 +29,7 @@ describe('git', function () {

mock.expects('execFile').withArgs('git', ['remote']).yieldsAsync(err, null)

return expect(git.exec(['remote']), 'to be rejected with', 'Git must be installed to use the Heroku CLI. See instructions here: http://git-scm.com')
return expect(git.exec(['remote']), 'to be rejected with', 'Git must be installed to use the Heroku CLI. See instructions here: https://git-scm.com')
})

it('exec passes through all other errors', function () {
Expand All @@ -56,7 +56,7 @@ describe('git', function () {
mock.expects('spawn').withExactArgs('git', ['remote'], { stdio: [0, 1, 2] }).returns(emitter)
process.nextTick(() => emitter.emit('error', err))

return expect(git.spawn(['remote']), 'to be rejected with', 'Git must be installed to use the Heroku CLI. See instructions here: http://git-scm.com')
return expect(git.spawn(['remote']), 'to be rejected with', 'Git must be installed to use the Heroku CLI. See instructions here: https://git-scm.com')
})

it('spawn passes through all other errors', function () {
Expand Down

0 comments on commit d54c394

Please sign in to comment.