Crash when auto-updating on OS X El Capitan (invalid memory address or nil pointer dereference)

[sbleon]

$ heroku config -r prod
Updating Heroku v4 CLI to 4.28.3-c46335c (master)... done
heroku-cli: Updating plugins... panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x1a1178]

goroutine 3 [running]:
panic(0x3f2f60, 0xc8200100f0)
    /usr/local/Cellar/go/1.6/libexec/src/runtime/panic.go:464 +0x3e6
github.com/heroku/heroku-cli/gode.(*Target).basePath(0x0, 0x0, 0x0)
    /Users/jdickey/src/github.com/heroku/heroku-cli/gode/target.go:19 +0xe8
github.com/heroku/heroku-cli/gode.(*Target).nodePath(0x0, 0x0, 0x0)
    /Users/jdickey/src/github.com/heroku/heroku-cli/gode/target.go:27 +0x8d
github.com/heroku/heroku-cli/gode.npmCmd(0xc8203b2fc0, 0xc, 0xc, 0x0, 0x0, 0x0)
    /Users/jdickey/src/github.com/heroku/heroku-cli/gode/packages.go:102 +0x14a
github.com/heroku/heroku-cli/gode.execNpm(0xc8203b2fc0, 0xc, 0xc, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /Users/jdickey/src/github.com/heroku/heroku-cli/gode/packages.go:121 +0x80
github.com/heroku/heroku-cli/gode.OutdatedPackages(0xc820344140, 0xa, 0xa, 0x351800, 0x0, 0x0)
    /Users/jdickey/src/github.com/heroku/heroku-cli/gode/packages.go:74 +0x1e0
main.updatePlugins()
    /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:82 +0x17e
main.Update.func1(0x528cd4, 0x6, 0xc820016060)
    /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:64 +0x35
created by main.Update
    /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:68 +0xac
 !    error getting commands pid 95242 exit 2

[trsantos]

Hi. I'm getting a similar error on FreeBSD since a few days ago:

% heroku
heroku-cli: Installing Toolbelt v4... done
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x59c308]

goroutine 3 [running]:
panic(0x7ec360, 0xc82000e180)
        /usr/local/Cellar/go/1.6/libexec/src/runtime/panic.go:464 +0x3e6
github.com/heroku/heroku-cli/gode.(*Target).basePath(0x0, 0x0, 0x0)
        /Users/jdickey/src/github.com/heroku/heroku-cli/gode/target.go:19 +0xe8
github.com/heroku/heroku-cli/gode.(*Target).nodePath(0x0, 0x0, 0x0)
        /Users/jdickey/src/github.com/heroku/heroku-cli/gode/target.go:27 +0x8d
github.com/heroku/heroku-cli/gode.IsSetup(0xc82043ec40, 0x0, 0x0)
        /Users/jdickey/src/github.com/heroku/heroku-cli/gode/setup.go:24 +0x33
main.SetupNode()
        /Users/jdickey/src/github.com/heroku/heroku-cli/plugins.go:32 +0x42
main.Update.func1(0x91fef0, 0x6, 0xc820012180)
        /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:64 +0x35
created by main.Update
        /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:69 +0xac
ERROR: runtime error: invalid memory address or nil pointer dereference
 !    error getting commands pid 1227 exit 1

[jdx]

I think you're on 4.27.5-39eade2 which was a bad release unfortunately. Can you delete ~/.heroku/heroku-cli and try again?

[trsantos]

Sure. But now, after deleting the entire .heroku directory, I got the following error:

% heroku
heroku-cli: Installing Toolbelt v4... done
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x59d088]

goroutine 3 [running]:
panic(0x808ea0, 0xc82000e170)
        /usr/local/Cellar/go/1.6/libexec/src/runtime/panic.go:464 +0x3e6
github.com/heroku/heroku-cli/gode.SetRootPath(0xc82043ec40, 0x14)
        /Users/jdickey/src/github.com/heroku/heroku-cli/gode/vars.go:41 +0x878
main.SetupNode()
        /Users/jdickey/src/github.com/heroku/heroku-cli/plugins.go:31 +0x3d
main.Update.func1(0x946b14, 0x6, 0xc820012180)
        /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:65 +0x35
created by main.Update
        /Users/jdickey/src/github.com/heroku/heroku-cli/update.go:70 +0xac
ERROR: runtime error: invalid memory address or nil pointer dereference
 !    error getting commands pid 26427 exit 1

Should I create a different issue for this?

[jdx]

can you try once more? I fixed that one this morning

[jdx]

It should be good now, I finally got around to setting up a freebsd vm

[trsantos]

Everything is ok now, thank you so much! BTW, it is also great that heroku can use the system's node from now on.