Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Consolidate use of real heroku apps in test/ #1482

Merged
merged 1 commit into from May 5, 2020
Merged

chore(ci): Consolidate use of real heroku apps in test/ #1482

merged 1 commit into from May 5, 2020

Conversation

mrmicahcooper
Copy link
Contributor

@mrmicahcooper mrmicahcooper commented Apr 16, 2020 •
edited

Stop using heroku-run-test-app and use heroku-cli-ci-smoke-test-app instead.

@mrmicahcooper
Use heroku-cli-ci-smoke-test-app for all apps in run/test
e7de589 
Consolidate the use of real heroku apps we test against
@mrmicahcooper mrmicahcooper requested a review from a team as a code owner April 16, 2020 14:58
jgwhite
jgwhite approved these changes May 5, 2020
View reviewed changes
Copy link

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible to me.

@mrmicahcooper mrmicahcooper merged commit 3ef7e11 into master May 5, 2020
@mrmicahcooper mrmicahcooper deleted the mc/use-heroku-cli-ci-smoke-test-app branch May 5, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgwhite jgwhite jgwhite approved these changes

@chadian chadian Awaiting requested review from chadian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrmicahcooper @jgwhite @Dhaulagiri