Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cli.log in pipelines:promote #1509

Merged
merged 1 commit into from May 11, 2020
Merged

fix: use cli.log in pipelines:promote #1509

merged 1 commit into from May 11, 2020

Conversation

RasPhilCo
Copy link
Contributor

@RasPhilCo RasPhilCo commented May 11, 2020 •
edited

cli.action.start in pipelines:promote is swallowing all error messages. This PR removes action in-favor of log while we investigate.

@RasPhilCo RasPhilCo requested a review from a team as a code owner May 11, 2020 20:48
eablack
eablack reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@eablack eablack left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a short description to the PR about why we're removing the usage of cli.action here? Just so if in the future we wonder why it's done this way there's some explanation somewhere.

@RasPhilCo RasPhilCo merged commit 3899d50 into master May 11, 2020
@RasPhilCo RasPhilCo deleted the pipeline-swallowing-error branch May 11, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eablack eablack eablack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RasPhilCo @eablack