Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pg-v5) only support default credential for connection pooling #1696

Merged
merged 1 commit into from Dec 16, 2020
Merged

fix(pg-v5) only support default credential for connection pooling #1696

merged 1 commit into from Dec 16, 2020

Conversation

verajohne
Copy link
Contributor

We only support default credential for connection pooling atm. Disallow non-default credentials

@verajohne verajohne requested a review from a team as a code owner December 10, 2020 15:05
subakva
subakva approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@subakva subakva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this never worked, I think it's good to remove the option and prevent confusion.

tmock12
tmock12 suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@tmock12 tmock12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind if we rename your PR fix(pg-v5) only support default credential for connection pooling so that it gets output in the changelog correctly?

Otherwise as long as we do only support default, this looks good to go.

@verajohne verajohne changed the title Only support default credential for connection pooling. fix(pg-v5) only support default credential for connection pooling Dec 15, 2020
@verajohne
Copy link
Contributor Author

mind if we rename your PR fix(pg-v5) only support default credential for connection pooling so that it gets output in the changelog correctly?

Otherwise as long as we do only support default, this looks good to go.

Done. Thanks :)

@mrmicahcooper mrmicahcooper merged commit c54e2ee into master Dec 16, 2020
@mrmicahcooper mrmicahcooper deleted the rm_credential_option branch December 16, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subakva subakva subakva approved these changes

@mrmicahcooper mrmicahcooper mrmicahcooper approved these changes

@tmock12 tmock12 tmock12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@verajohne @subakva @mrmicahcooper @tmock12