Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double updating bug #215

Merged
merged 2 commits into from
Mar 3, 2016
Merged

fix double updating bug #215

merged 2 commits into from
Mar 3, 2016

Conversation

jdx
Copy link
Contributor

@jdx jdx commented Mar 3, 2016

running heroku update still causes the blocking update to run. This is happening because when the CLI is updated, the update lock file is cleared to force an autoupdate and reexec of the command. Generally this is good, because it will make sure that everything is updated using the new CLI. The problem is when the command is actually update, it will force a blocking update, then run the command which is to update.

This just checks before running a blocking update if the command is to update. If so, there is no need to do the blocking update step.

before:

$ heroku update master
Updating Heroku v4 CLI to 4.27.25-3b727e5 (master)... done
heroku-cli: Adding dependencies... done
Updating plugins... no plugins to update.
Updating plugins... no plugins to update.

after:

$ heroku update dev
Updating Heroku v4 CLI to 4.27.25-b97ac29 (dev)... done
heroku-cli: Adding dependencies... done
heroku-cli: Updating plugins... no plugins to update.

@jdx
Copy link
Contributor Author

jdx commented Mar 3, 2016

ready for review @ransombriggs

@jdx jdx force-pushed the update-fix branch 3 times, most recently from 3c6caf7 to 437520d Compare March 3, 2016 20:12
dickeyxxx added 2 commits March 3, 2016 12:14
if you run `heroku update` and it updates the CLI it
prints `Updating plugins...` twice
@ransombriggs
Copy link

@dickeyxxx lgtm

jdx pushed a commit that referenced this pull request Mar 3, 2016
@jdx jdx merged commit b0d96b6 into master Mar 3, 2016
@jdx jdx deleted the update-fix branch March 3, 2016 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants