fix bugs with plugin parsing #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
force-pushed
the
fix-stderr-plugin-init
branch
from
c5a7325
to
c40946e
Compare
|
ready for review @ransombriggs |
| if err != nil { | ||
| return nil, fmt.Errorf("Error reading plugin: %s\n%s\n%s", name, err, string(output)) | ||
| return nil, fmt.Errorf("Error reading plugin: %s\n", name) |
There was a problem hiding this comment.
@dickeyxxx why did you remove err from the Error reading plugin string?
There was a problem hiding this comment.
oh I guess I can include that part
jdx
force-pushed
the
fix-stderr-plugin-init
branch
from
c40946e
to
a0586f5
Compare
If the plugin fails to parse it formerly would just exit silently and all plugins would fail to install. Also, if the plugin output anything on stderr it would try to parse it and also fail. This redirects stderr out to the terminal and shows the parsing error if any.
|
@dickeyxxx lgtm |
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
* Adjust 'heroku releases' output to fit terminal width * Trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin fails to parse it formerly would just exit silently and
all plugins would fail to install.
Also, if the plugin output anything on stderr it would try to parse it
and also fail.
This redirects stderr out to the terminal and shows the parsing error if
any.