feat(redis-v5/pg-v5): Update Redis/PG maintenance commands to suggest Data Maintenance CLI #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iriberri
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
…heroku/cli into ci-maintenance_command_warnings
|
The linter is very unhappy. I'll try fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Data Maintenance CLI (https://devcenter.heroku.com/articles/data-maintenance-cli-commands) was released a while ago and we want to recommend customers to switch to these new maintenance commands instead, which require the installation of an extra plugin.
This PR includes those changes for each of the maintenance-related commands for both Redis and Postgres add-ons on Heroku.
We will be making a few other changes from the Data side as well to match this. I expect this to be a short/medium-term change while we work towards deprecating the old commands.
The texts have been reviewed/suggested by CX already. I tried adapting to the existing content and tests but I'm really not very familiarised with JS neither how we develop for the CLI specially. If there's anything I need to adjust or any best practices I should be following, please, let me know!
Thank you.
cc: @jbrown-heroku (Product), @heicheng18 (CX)