fix: release workflow trigger & others #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest_target which seems to work reliably
…imply in the environment
k80bowman
previously approved these changes
May 30, 2023
…guard in appropriate places.
…instead of separate file separate publish npm & release GH into workflows and better name npm scripts
k80bowman
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug(feature?) in GHA
on: pull_requestthat leads to it not always running on closed pull requests.Refactor various triggers, inputs and entry points to ensure safeguards in appropriate places.
Attempt to manually log in to GH cli by running
gh auth login --with-tokenwith GITHUB_TOKENFix error in release-homebrew.yml. Multiple environment secrets can not be used in 1 job. Moved S3 & CloudFront secrets to repo level.