Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): remove fig command & update workflow #2686

Merged
merged 12 commits into from Mar 8, 2024
8 changes: 5 additions & 3 deletions .github/workflows/publish-to-fig-autocomplete.yml
Expand Up @@ -14,20 +14,22 @@ jobs:
with:
node-version: 16.x
cache: yarn
- name: Install Fig Oclif Plugin
run: cd packages/cli && yarn add @fig/complete-oclif && jq '.oclif.plugins += ["@fig/complete-oclif"]' package.json > temp.json && mv temp.json package.json
- run: yarn --immutable --network-timeout 1000000
- name: Build Heroku CLI
run: yarn build
- name: Generate Fig Spec
run: ./bin/run generate-fig-spec > spec.ts
run: cd packages/cli && ./bin/run generate-fig-spec > spec.ts
- name: Get Heroku Version
id: cli-version
run: echo "version=$(./bin/run --version | sed -rn 's/^heroku\/([0-9\.]+).*$/\1/p')"
- name: Create Fig Autocomplete PR
uses: withfig/push-to-fig-autocomplete-action@v1
uses: withfig/push-to-fig-autocomplete-action@v2
with:
token: ${{ secrets.HEROKU_CLI_BOT_TOKEN }}
autocomplete-spec-name: 'heroku'
spec-path: spec.ts
spec-path: ./packages/cli/spec.ts
integration: oclif
diff-based-versioning: true
new-spec-version: ${{ steps.cli-version.outputs.version }}
Expand Down
2 changes: 0 additions & 2 deletions packages/cli/package.json
Expand Up @@ -6,7 +6,6 @@
"bin": "./bin/run",
"bugs": "https://github.com/heroku/cli/issues",
"dependencies": {
"@fig/complete-oclif": "^2.0.0",
"@heroku-cli/color": "1.1.14",
"@heroku-cli/command": "^10.0.0",
"@heroku-cli/command-v9": "npm:@heroku-cli/command@^9.0.2",
Expand Down Expand Up @@ -156,7 +155,6 @@
],
"commands": "./lib/commands",
"plugins": [
"@fig/complete-oclif",
"@oclif/plugin-legacy",
"@heroku-cli/plugin-addons-v5",
"@heroku-cli/plugin-apps-v5",
Expand Down
1 change: 0 additions & 1 deletion packages/cli/test/acceptance/commands-output.ts
Expand Up @@ -124,7 +124,6 @@ export default `\u001B[1m Command Summary
features:disable disables an app feature
features:enable enables an app feature
features:info display information about a feature
generate-fig-spec Generate a Fig completion spec
git:clone clones a heroku app to your local machine at DIRECTORY (defaults to app name)
git:remote adds a git remote to an app repo
help Display help for heroku.
Expand Down
20 changes: 0 additions & 20 deletions yarn.lock
Expand Up @@ -1128,16 +1128,6 @@ __metadata:
languageName: node
linkType: hard

"@fig/complete-oclif@npm:^2.0.0":
version: 2.0.0
resolution: "@fig/complete-oclif@npm:2.0.0"
dependencies:
"@oclif/core": ^2.8.11
prettier: ^3.1.1
checksum: c7b148073456723cd85baaab5179a667c8078fb317ea03e184523ac9164ac4ff8f80452006c527e9c4340b08467fe480a2046554a5e6ca75b2e3aa1f27cac8da
languageName: node
linkType: hard

"@gar/promisify@npm:^1.0.1, @gar/promisify@npm:^1.1.3":
version: 1.1.3
resolution: "@gar/promisify@npm:1.1.3"
Expand Down Expand Up @@ -10972,7 +10962,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "heroku@workspace:packages/cli"
dependencies:
"@fig/complete-oclif": ^2.0.0
"@heroku-cli/color": 1.1.14
"@heroku-cli/command": ^10.0.0
"@heroku-cli/command-v9": "npm:@heroku-cli/command@^9.0.2"
Expand Down Expand Up @@ -15650,15 +15639,6 @@ __metadata:
languageName: node
linkType: hard

"prettier@npm:^3.1.1":
version: 3.2.5
resolution: "prettier@npm:3.2.5"
bin:
prettier: bin/prettier.cjs
checksum: 2ee4e1417572372afb7a13bb446b34f20f1bf1747db77cf6ccaf57a9be005f2f15c40f903d41a6b79eec3f57fff14d32a20fb6dee1f126da48908926fe43c311
languageName: node
linkType: hard

"pretty-bytes@npm:^5.3.0":
version: 5.6.0
resolution: "pretty-bytes@npm:5.6.0"
Expand Down