This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Port Ruby Index to Match PHP Index #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the example and pushed to the above url again. Added in some missing elements. If you want to test out the authentication after you've already given it permission. You can remove 'Fugu' from your apps by going to http://www.facebook.com/settings/?tab=privacy then clicking on Apps, then Fugu, the remove. This will require that you re-auth with Facebook. The one difference between this app and the php one, is we are using mogli for Facebook authentication so there will be a page refresh when you click the login button |
| <link rel="stylesheet" href="stylesheets/mobile.css" media="handheld, only screen and (max-width: 480px), only screen and (max-device-width: 480px)" type="text/css" /> | ||
|
|
||
| <!--[if IEMobile]> | ||
| <link rel="stylesheet" href="mobile.css" media="screen" type="text/css" /> |
There was a problem hiding this comment.
not sure about that code, i got this straight from the php code which seems to work. Though I don't have an IEMobile device to test it with :/
schneems
added a commit
that referenced
this pull request
Feb 25, 2012
Port Ruby Index to Match PHP Index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I ported the Ruby default index to match the default PHP index.
Why
To keep things standard across languages
Outcome
You can see the updated page in production here Ruby Facebook Template index compared to the PHP Facebook Template index.
What I Need
If no one has any objections, I'll merge it in.