-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Heroku-20 #12
Comments
Option 2 (make it heroku-20+ only) seems best to me. That way a behavior change is tied to a stack update. |
So mulling over this some more - I think this option is the best way to roll out the change initially, however long term we should backport the change to older stacks. The reason for this is that we hang too many breaking changes on the stack change, which then only ends up making stack upgrades harder for users, when they have to deal with half a dozen breaking changes at once. Also for this buildpack usage is extremely low. |
There are actually fewer breaking changes than I expected: |
I just pushed a PR that updates awscli to v2 and fixes this issue: #15 |
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12.
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12.
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12.
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12.
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12.
Updates from the deprecated v1 AWS CLI to v2: https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst This fixes compatibility with Heroku-20. In addition: * the file copying approach to working around non-relocatability has been replaced with a symlink approach for faster build times. * this approach also means using an `export` file is now viable, so one has been created allowing later buildpacks to use the CLI and not just runtime use-cases. * the buildpack now outputs the installed version to the log, for easier debugging. Fixes #7. Fixes #12. Closes W-8520499.
Building an app using this buildpack on Heroku-20 resulted in this output (the build itself didn't fail; for which I'll file a separate issue):
This is because on Heroku-20,
python
is now Python 3, not Python 2, and because under Python 3.7+ AWS CLI v1 tries to usevenv
rather than thevirtualenv
package:Looking at the latest AWS CLI docs, they now tell users to install AWS CLI v2 instead:
https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html
Although that version only supports Python 3.7+, so would only work on Heroku-18+, plus has other breaking changes:
https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html
It seems like our options are to:
python3-venv
package (which isn't a package we've previously made available)@dzuelke @dmathieu Thoughts? (Context: This blocks W-8287887).
The text was updated successfully, but these errors were encountered: