Add .gitmodules #134
Closed
Add .gitmodules #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been added in d0ff462, and not having it committed means `git clone --recursive` fails on this repository: ``` $ git clone --recursive --quiet https://github.com/heroku/heroku-buildpack-go.git No submodule mapping found in .gitmodules for path 'test/fixtures/glide-with-deps/vendor/github.com/heroku/slog' ``` Signed-off-by: Lewis Marshall <lewis@lmars.net>
lmars
added a commit
to flynn/flynn
that referenced
this pull request
Jun 8, 2016
The Go buildpack is currently failing to clone due to a missing .gitmodules file (see heroku/heroku-buildpack-go#134). Given we checkout an explicit version, there is no need to checkout origin/HEAD first. Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
Closed via 928a49e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been added in d0ff462, and not having it committed means
git clone --recursivefails on this repository: