Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require gradle wrapper and use gradlew script as detection hueristic #17

Closed
ldaley opened this issue Apr 3, 2014 · 3 comments
Closed

Require gradle wrapper and use gradlew script as detection hueristic #17

ldaley opened this issue Apr 3, 2014 · 3 comments

Comments

@ldaley
Copy link
Contributor

ldaley commented Apr 3, 2014

Hi,

I think it would be better for everyone if the buildpack required the Gradle wrapper. All projects should use the wrapper and relying on the version provided by Heroku is fragile at best.

I'm happy to supply the PR if it's agreed that this is the way to go.
@davidmc24
Copy link
Contributor

I agree with this suggestion.

@Zenedith
Copy link

Zenedith commented Apr 3, 2014

👍

@fge
Copy link

fge commented Apr 8, 2014

Definitely agreed. All that the wrapper needs is a JDK installed. And it leaves the freedom for users to use the version they want and not forcefeed them a version they don't want to use.

ldaley added a commit to ldaley/heroku-buildpack-gradle that referenced this issue Aug 25, 2014
@ldaley
Require Gradle Wrapper (heroku#17)
f39fc45
@jkutner jkutner closed this as completed Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jkutner @ldaley @Zenedith @davidmc24 @fge