Skip to content

Commit

Permalink
Make breaking change warning header brighter
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremy Morrell authored and jmorrell committed Mar 4, 2019
1 parent 1bc7e18 commit 5d1e6f7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bin/compile
Expand Up @@ -330,7 +330,7 @@ warn_no_start "$BUILD_DIR"
warn_unmet_dep "$LOG_FILE"
warn_old_npm_lockfile $NPM_LOCK

warn_build_script_behavior_change "$NEW_BUILD_SCRIPT_BEHAVIOR" "$BUILD_DIR" | output "$LOG_FILE"
warn_build_script_behavior_change "$NEW_BUILD_SCRIPT_BEHAVIOR" "$BUILD_DIR"
warn_build_script_behavior_opt_in "$NEW_BUILD_SCRIPT_BEHAVIOR" | output "$LOG_FILE"
log_build_script_opt_in "$NEW_BUILD_SCRIPT_BEHAVIOR" "$BUILD_DIR"

Expand Down
2 changes: 1 addition & 1 deletion lib/dependencies.sh
Expand Up @@ -80,7 +80,7 @@ warn_build_script_behavior_change() {
has_heroku_build_script=$(read_json "$build_dir/package.json" ".scripts[\"heroku-postbuild\"]")

if [[ -z "$has_heroku_build_script" ]] && [[ -n "$has_build_script" ]] && [[ "$opted_in" != "true" ]]; then
header "Change to Node.js build process"
bright_header "Change to Node.js build process"
echo "On March 11, 2019 Heroku will begin executing the \"build\" script defined in package.json"
echo "by default. This application may be affected by this change."
echo ""
Expand Down
5 changes: 5 additions & 0 deletions lib/output.sh
Expand Up @@ -28,6 +28,11 @@ header() {
echo "-----> $*" || true
}

bright_header() {
echo "" || true
echo -e "\033[1;33m-----> $* \033[0m"
}

header_skip_newline() {
echo "-----> $*" || true
}
Expand Down

0 comments on commit 5d1e6f7

Please sign in to comment.