Merge pull request #326 from heroku/fix-remove-devdeps-log

remove debugging log for devdeps
heroku · Jul 1, 2016 · 75ac192 · 75ac192
2 parents 750b2fe + c764e7a
commit 75ac192
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/failure.sh b/lib/failure.sh
@@ -99,12 +99,11 @@ warn_angular_resolution() {
 warn_missing_devdeps() {
   local log_file="$1"
   if grep -qi 'cannot find module' "$log_file"; then
-    warning "A module may be missing from package.json" "https://devcenter.heroku.com/articles/troubleshooting-node-deploys#ensure-you-aren-t-relying-on-untracked-dependencies"
+    warning "A module may be missing from 'dependencies' in package.json" "https://devcenter.heroku.com/articles/troubleshooting-node-deploys#ensure-you-aren-t-relying-on-untracked-dependencies"
     if [ "$NPM_CONFIG_PRODUCTION" == "true" ]; then
       local devDeps=$(read_json "$BUILD_DIR/package.json" ".devDependencies")
-      echo "devDependencies: $devDeps"
       if [ "$devDeps" != "" ]; then
-        warning "A module may be specified in devDependencies instead of dependencies" "https://devcenter.heroku.com/articles/nodejs-support#devdependencies"
+        warning "This module may be specified in 'devDependencies' instead of 'dependencies'" "https://devcenter.heroku.com/articles/nodejs-support#devdependencies"
       fi
     fi
   fi

diff --git a/test/run b/test/run
@@ -31,15 +31,15 @@ testWarnNoStart() {
 testWarnDevDeps() {
   compile "missing-devdeps-1"
   assertCaptured "A module may be missing"
-  assertNotCaptured "A module may be specified"
+  assertNotCaptured "This module may be specified"
   assertCapturedError
   compile "missing-devdeps-2"
   assertCaptured "A module may be missing"
-  assertCaptured "A module may be specified"
+  assertCaptured "This module may be specified"
   assertCapturedError
   compile "failing-build"
   assertNotCaptured "A module may be missing"
-  assertNotCaptured "A module may be specified"
+  assertNotCaptured "This module may be specified"
   assertCapturedError
 }