manual default for yarn version #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
approved these changes
Sep 6, 2017
|
There was a "Heroku fix" in yarn v1.0.1 (yarnpkg/yarn#4325), but until today, https://semver.io/yarn/resolve/1.0.x has returned |
|
@steffenagger The Node buildpack no longer uses semver.io We would like to not have to keep bumping the default version manually. We will likely use the version marked as stable by the yarn website + some smoke tests to decide the default. |
|
Arh, thanks @jmorrell, just thought I saw an error mentioning semver.io when yarn 1.0.1 was just released... I now see (in this PR) that it's actually not used. Sorry for wasting your time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick patch for #468 while we work on a better solution.