Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set $NPM_REBUILD to rebuild cached deps #84

Closed
wants to merge 1 commit into from

Conversation

mojodna
Copy link

@mojodna mojodna commented Dec 13, 2013

When composed with other buildpacks, underlying dependencies (e.g. mapnik may have changed causing the cached binaries to link to incorrect versions. If prior buildpacks (or users) set $NPM_REBUILD, cached modules will be rebuilt.

When composed with other buildpacks, underlying dependencies may have
changed causing the cached binaries to link to incorrect versions. If
prior buildpacks (or users) set $NPM_REBUILD, cached modules will be
rebuilt.
@zeke
Copy link
Contributor

zeke commented Feb 15, 2014

@mojodna are you using this with user-env-compile enabled? We are in the process of making user-env-compile the default for all apps. This effectively means config vars will be available to the buildpacks compile script as environment variables.

@mojodna
Copy link
Author

mojodna commented Feb 15, 2014

Yup. This means that other buildpacks can manipulate config vars?

The same use-case applies, so let me know if I should update the pull.

@zeke
Copy link
Contributor

zeke commented Feb 15, 2014

This means other buildpacks can read config vars, but not manipulate them. (Thought buildpacks can manipulate the environment with a .profile.d script.)

If you don't mind, let's leave this PR open until user-env-compile becomes the default for all apps.

@mojodna
Copy link
Author

mojodna commented Feb 15, 2014

Is there a blessed way to pass environment vars between buildpacks (e.g. LIBRARY_PATH, etc.)? ddollar/heroku-buildpack-multi#18, essentially.

@zeke
Copy link
Contributor

zeke commented Jun 20, 2014

Hey @mojodna, it's now possible to access config vars during build without using user-env-compile (which is now dead. Yay!). Does this change in this PR still reflect a need that you have?

@mojodna
Copy link
Author

mojodna commented Jun 20, 2014

Not recently, no. I'll close.

@mojodna mojodna closed this Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants