Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the JSON mime type when uploading JSON manifests to S3 #173

Merged
merged 1 commit into from Oct 4, 2016
Merged

Use the JSON mime type when uploading JSON manifests to S3 #173

merged 1 commit into from Oct 4, 2016

Conversation

stof
Copy link
Contributor

@stof stof commented Jul 20, 2016

The guessing algorithm of s3cmd detects them as text/plain.

Closes #172

@stof
Use the JSON mime type when uploading JSON manifests to S3
62ed4b5 
The guessing algorithm of s3cmd detects them as text/plain.
@stof
Copy link
Contributor Author

stof commented Aug 30, 2016

@dzuelke ping

@stof
Copy link
Contributor Author

stof commented Oct 3, 2016

@dzuelke any news about this PR ?

@dzuelke dzuelke changed the base branch from master to develop October 3, 2016 23:27
@freeformz
Copy link

2 Comments:

  1. You may also be able to use -M here which will guess the mime type based on file extension or "mime magic". Not sure if that will apply nicely in all cases and I prefer being explicit anyway.
  2. The s3cmds look awfully alike, so you could possibly DRY them up a bit. Not sure it's actually worth it though.

With that said though it LGTM, 👍

@dzuelke dzuelke merged commit 7bfc7de into heroku:develop Oct 4, 2016
@stof stof deleted the json_mime_type branch October 4, 2016 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stof @freeformz @dzuelke